Skip to content

Comments

Decompile link_dialog (and the rest of the menu virtual functions)#49

Merged
Eebit merged 5 commits intomainfrom
link_dialog
Feb 5, 2026
Merged

Decompile link_dialog (and the rest of the menu virtual functions)#49
Eebit merged 5 commits intomainfrom
link_dialog

Conversation

@Eebit
Copy link
Owner

@Eebit Eebit commented Feb 5, 2026

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Feb 5, 2026

Report for YFEE01 (420e2f1 - 90d6c32)

📈 Matched code: 5.98% (+0.14%, +2468 bytes)

✅ 103 new matches
Unit Item Bytes Before After
src/link_dialog func_02014b20 +752 0.00% 100.00%
src/link_dialog LinkDialogBlink::Loop() +96 0.00% 100.00%
src/link_dialog _LinkDialogCommon::vfunc_20(long) +88 0.00% 100.00%
src/link_dialog _LinkDialogNone::vfunc_11c() +88 0.00% 100.00%
src/link_dialog LinkDialogBlink::~LinkDialogBlink() +72 0.00% 100.00%
src/link_dialog LinkDialogBlink::~LinkDialogBlink() +64 0.00% 100.00%
src/link_dialog _LinkDialogYesNo::vfunc_28(long) +48 0.00% 100.00%
src/link_dialog MenuItem::vfunc_9c(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_90(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_84(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_78(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_6c(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_60(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_54(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_48(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_3c(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_30(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_24(Menu*, MenuItemState*) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_60() +24 0.00% 100.00%
src/link_dialog Menu::vfunc_5c(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_54(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_4c(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_44(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_3c(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_34(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_2c(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog Menu::vfunc_24(MenuItemState*, long) +24 0.00% 100.00%
src/link_dialog MenuItem::vfunc_a4(MenuItemState*) +20 0.00% 100.00%
src/link_dialog MenuItem::vfunc_98(MenuItemState*) +20 0.00% 100.00%
src/link_dialog MenuItem::vfunc_8c(MenuItemState*) +20 0.00% 100.00%

...and 73 more new matches

📈 21 improvements in unmatched items
Unit Item Bytes Before After
src/link_dialog .data +3523 0.00% 85.85%
src/link_dialog func_02014834 +653 0.00% 97.75%
src/link_dialog _LinkDialogYesNo::vfunc_00() +307 0.00% 99.95%
src/link_dialog _LinkDialogCommon::vfunc_00() +303 0.00% 99.95%
src/link_dialog _LinkDialogNone::vfunc_10() +122 0.00% 98.39%
src/link_dialog _LinkDialogNone::~_LinkDialogNone() +107 0.00% 99.96%
src/link_dialog func_02014e10 +99 0.00% 99.96%
src/link_dialog _LinkDialogNone::~_LinkDialogNone() +99 0.00% 99.96%
src/link_dialog _LinkDialogCommon::~_LinkDialogCommon() +83 0.00% 99.95%
src/link_dialog _LinkDialogYesNo::~_LinkDialogYesNo() +83 0.00% 99.95%
src/link_dialog _LinkDialogConfirm::~_LinkDialogConfirm() +83 0.00% 99.95%
src/link_dialog _LinkDialogCommon::~_LinkDialogCommon() +75 0.00% 99.95%
src/link_dialog _LinkDialogYesNo::~_LinkDialogYesNo() +75 0.00% 99.95%
src/link_dialog _LinkDialogConfirm::~_LinkDialogConfirm() +75 0.00% 99.95%
src/link_dialog func_02014af4 +43 0.00% 99.64%
src/link_dialog func_02014ad0 +35 0.00% 99.89%
src/link_dialog LinkDialogItemNoF::vfunc_1c() +23 0.00% 99.83%
src/link_dialog LinkDialogItemNo::vfunc_1c() +23 0.00% 99.83%
src/link_dialog LinkDialogItemYes::vfunc_1c() +23 0.00% 99.83%
src/link_dialog LinkDialogBlink_Loop +19 0.00% 99.80%
src/link_dialog .bss +16 0.00% 25.00%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
src/ov005/prep_main_menu func_ov005_022057e4 0 99.77% 99.76%

@Eebit Eebit marked this pull request as ready for review February 5, 2026 03:25
@Eebit Eebit merged commit b44c19c into main Feb 5, 2026
2 checks passed
@Eebit Eebit deleted the link_dialog branch February 5, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant